Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSUB "support" #43

Open
mhaberler opened this issue Jun 30, 2016 · 3 comments
Open

XSUB "support" #43

mhaberler opened this issue Jun 30, 2016 · 3 comments

Comments

@mhaberler
Copy link
Member

we have some interest in an embedded client which would need to do both DEALER and XSUB (NB @zhivko)

it turns out the dealer socket works just fine with an XSUB publisher, see testxsub.c in https://github.com/mhaberler/libzmtp/commits/xpub

happy to take recommendations what to do with this

I see how I could do a ROUTER pthread for a dealer selftest
I do not see how I could do a XPUB pthread - unclear how to manage subscriptions

is it worth writing zmtp_router.c, zmtp_xsub.c classes?

@hurtonm
Copy link
Member

hurtonm commented Jun 30, 2016

Hi Michael, I think it makes perfect sense to add support for XSUB socket type. is it your idea to contribute patches for this?

@mhaberler
Copy link
Member Author

fine - it's just that it will be a rather boring copy & paste job on zmtp_dealer.c with renamed methods - plus subscribe/unsubscribe methods

if that is OK I'll do it and give it a stab at selftests

@hurtonm
Copy link
Member

hurtonm commented Jun 30, 2016

yes, but often that creates an opportunity to refactor existing code base and that usually is rewarding experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants