-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curve not enabled by default #640
Comments
Curve is not included in the prebuilt binaries anymore following the upstream approach. You should build the binaries from the source if that is desired. |
so adding build_from_source=true and setting is enough to get curve? |
nope, still want work |
would be super helpful if someone could do a little documentation on how to turn on curve |
@aminya is it planned that curve will be reintegrated into the prebuilt binaries? |
Curve needs to be added to the project prebuilds so it works out of the box. You can expedite the process by sponsoring the project |
I have migrated the build to CMake/vcpkg. Now you can enable the |
Hi, @aminya Tried installing
But when I run this snippet [on a ubuntu machine]:
I get |
It should have worked, if it doesn't that's an issue we need to look into. Did it rebuild Zeromq from the source once you did this? |
I think so. At least the first time I attempted to do |
Ok. Thanks for the report. I'll soon try to add it to the CI and reproduce it. |
@aminya I can confirm that adding:
to Here's my scenario: We were using wsiZmqDealerSock = new Dealer({
routingId: ZMQ_ROUTING_ID,
sendTimeout: 0,
reconnectInterval: 2000,
curveServer: false,
curveServerKey: spk,
curvePublicKey: cpk,
curveSecretKey: csk
}) However, we removed and re-generated our
After this, the Dealer code above would not work. After investigating, I found the documentation for enabling curve via Tried a few things, for instance I edited - option(ZMQ_CURVE "Enable CURVE security" OFF)
+ option(ZMQ_CURVE "Enable CURVE security" ON) Then I ran:
However, my code still failed with the same error. Not sure if the above information helps, I hope it will, but admittedly I'm not that familiar with CMake so I'm not even sure if what I did was right. |
Update: By adding the following line to
I was able to confirm that the curve feature was now included in
This is only after I force However, my Dealer instantiation still errors out with Full install log file attached. |
@aminya I sponsored and I'm hoping you have some time to take a 👀 |
Thanks very much! I'll have a look soon. |
@aminya 👋 Just wanted to check if you've had time to look at this, if not would you be able to advise an approximate time to check back in? |
@ctataryn I've been very busy this week, but I'll work on Curve this weekend! Thanks for waiting. |
@aminya Thanks for the update, I appreciate it! |
libzmq no longer provides curve support without enabling libsodium. This was introduced in 4.3.5. So, in #682, I have updated the readme to reflect that accordingly. You have to enable both in the zmq_curve="true"
zmq_sodium="true" You can try to build this locally, while I make #682 working for all platforms. |
following some examples of implementing curve on a pub/sub i get cannot set public, secret or server public keys
setting socket.curveserver = true throws exceptions too.
The text was updated successfully, but these errors were encountered: