Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unformatted data field for UniqueCountReducer #1189

Open
lcjohnso opened this issue Jul 28, 2020 · 0 comments
Open

Unformatted data field for UniqueCountReducer #1189

lcjohnso opened this issue Jul 28, 2020 · 0 comments
Labels

Comments

@lcjohnso
Copy link
Member

Expected Behavior: UniqueCountReducer (and SqsReducer) should return data formatted as a hash.

Current Behavior: unlike other Reducers, the UniqueCountReducer does not return a key-value hash in its data field. The same issue applies to SqsReducer, which returns "dispatched" in data when no other data field or hash is provided.

Consequences: Many pieces of Caesar code assume that a reduction's data will be a hash. As a result: exports fail, views fail, reduction results can't be accessed by rules, etc.

Potential Solution: For UniqueCountReducer, the update could be as simple as adding a key (e.g., count) for the returned value, and return key-value pair as a hash for the reduction's data.

@lcjohnso lcjohnso added the bug label Jul 28, 2020
@lcjohnso lcjohnso changed the title Bug: unformatted data field for UniqueCountReducer Unformatted data field for UniqueCountReducer Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant