Eliminate duplicated strings in bundle #48
Closed
+150
−102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-using
Kind
should remove a lot of the duplicated strings in our bundle as well as increase performance due to a reduction of adhoc String allocations.EDIT: hmm, I would have assumed that the variable usage would improve the bundle size, not worsen it 😅 this is a bit odd to say the least, I guess the repeated strings is being offset due to GZIP