Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate duplicated strings in bundle #48

Closed
wants to merge 2 commits into from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Dec 23, 2024

Summary

Re-using Kind should remove a lot of the duplicated strings in our bundle as well as increase performance due to a reduction of adhoc String allocations.

EDIT: hmm, I would have assumed that the variable usage would improve the bundle size, not worsen it 😅 this is a bit odd to say the least, I guess the repeated strings is being offset due to GZIP

Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: cbb4c80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Size Change: +80 B (+1.64%)

Total Size: 4.96 kB

Filename Size Change
dist/graphql.web.js 4.96 kB +80 B (+1.64%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant