Remove risks of panic #1231
Merged
Remove risks of panic #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@npwardberkeley Would you mind having a look when you have time? That's not a super rich PR but the test runner / cluster would break unexpectedly with those conditions not respected (and a bunch of tests from the EVM test suite do not abide). |
Co-authored-by: Nicholas Ward <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
as_u32/as_u64methods ofU256will panic if the integer is actually greater, which is not ideal.This PR handles soft conversions which error instead of panicking.
Also prevents panicking from the interpreter methods and tests.