Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] booleano import error #324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elvismdev
Copy link

@elvismdev elvismdev commented May 14, 2018

What does this PR do ?

Fixes error:

:~/WWW/jqvmap/create$ python jqvmap.py config/country-name.json
Traceback (most recent call last):
  File "jqvmap.py", line 11, in <module>
    from booleano.parser import Grammar, EvaluableParseManager, SymbolTable, Bind
ImportError: cannot import name EvaluableParseManager

How should this be tested ?

With

  • Python 2.7.12
  • GDAL 2.1.3
  • Shapely 1.2.16
  • Booleano 1.1a2
    • pyparsing 2.2.0
    • six 1.10.0

Run

python jqvmap.py config/country-name.json

// config/country-name.json

[
  {
    "name": "read_data",
    "file_name": "./source/gadm36_CUB_shp/gadm36_CUB_0.shp"
  },
  {
    "name": "write_data",
    "format": "jqvmap",
    "file_name": "./output/jquery.vmap.country-name.js",
    "params": {
      "code_field": "ISO",
      "name_field": "NAME_ENGLI",
      "name": "country-name"
    }
  }
]

What are the relevant issues ?

bjornd/jvectormap#352 (comment)

This Pull Request includes:

  • Bug Fix with passing npm test
  • New Feature with passing npm test
  • Code Improvement with passing npm test
  • Updated Documentation
  • New Map File & Example HTML

What gif best describes how you feel about this work ?

cool

@iqnaul
Copy link

iqnaul commented May 14, 2018

Hi, I'm still experiencing error message:
ImportError: cannot import name 'EvaluableParseManager'

I have booleano correctly installed, do you have any suggestion?

@elvismdev
Copy link
Author

@iqnaul This PR fixes that, but it has still to be merged to master. In the meantime you could manually apply this change on your end 75487ab

@iqnaul
Copy link

iqnaul commented May 15, 2018

okay thank you @elvismdev I applied this and try it but still experience about utf-8 encoding

@elvismdev
Copy link
Author

@iqnaul utf-8 encoding looks like a separate issue from what this PR fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants