-
Notifications
You must be signed in to change notification settings - Fork 83
Redis #118
base: develop
Are you sure you want to change the base?
Redis #118
Conversation
I understand that redis is important for some projects, but I think this PR is not ready for the release yet because we can't accept it as is. If we want to add redis support, we need to modify the create command to ask users which caching service they want to use and let them select between memcached and redis. @jamesmorrison do you mind to rebase your branch against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to do the following:
- rebase agains
release/2.8.0
branch; - ask users which caching service they want to use and let them to select between memcached and redis;
- update docker-composer config creation script to use caching service selected by the user;
- update init command to ask the same question and save user selection in the config file;
- add redis image to the images list, so it gets updated when we update images with
image update
command; - update changelog.
@jamesmorrison are you able to help work through any of the 6 items that Eugene noted in his prior review comment? |
👋🏻 @jeffpaul - Yes I'd like to finish this up, it didn't slip my mind but I haven't found time to work on this yet. I've recently completed a Node CLI course; and have been exploring Docker / Docker Compose a lot recently so it would be nice to see this through! |
Description of the Change
Adding Redis object caching support
Alternate Designs
Benefits
Many projects are hosted on platforms using Redis rather than Memcached, adding support for Redis allows the object cache to be utilised and tested locally as well as on staging environments prior to a production release.
Possible Drawbacks
Verification Process
This was tested on a project locally, in conjunction with WP Redis and a standard configuration and showed the object cache was functioning correctly:
Checklist:
Applicable Issues
Changelog Entry
Added Redis Object Cache support.