Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISC] Whitelist immediate change #2133

Merged

Conversation

benzok
Copy link
Contributor

@benzok benzok commented Dec 14, 2024

Today when adding a BLE device that is auto discovered you need to temporarily disable the white-list first and then add the new device to the list, as described in the docs.

With this change you just update the list and it gets discovered. (You need to restart the gateway if you have not enabled discovery)

See discussion in Theengs community

The PR has been built and tested on environment esp32-lolin32lite-ble

Checklist:

  • [ x] The pull request is done against the latest development branch
  • [ x] Only one feature/fix was added per PR and the code change compiles without warnings
  • [ x] I accept the DCO.

@DigiH
Copy link
Collaborator

DigiH commented Dec 14, 2024

Thanks @benzok , also for amending the documentation, but the optional commands how to temporarily disable or enable white/black lists need to remain, as these are still useful working commands.

Just the top paragraph about this being required for new white-list discoveries can go.

@DigiH DigiH changed the title Whitelist immediate change [DISC] Whitelist immediate change Dec 14, 2024
@1technophile
Copy link
Owner

Thanks

@1technophile 1technophile merged commit 312b4bc into 1technophile:development Dec 18, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants