Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

juju and dungeoneering potions and water and herbs and spawns and npc examine text and todo for potions #519

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

MrSlayerGod
Copy link
Contributor

@MrSlayerGod MrSlayerGod commented Feb 16, 2024

What has been done?

• Addition of Juju and Dungeoneering Potions:
    • Implemented compatibility for using Juju vial of water and Dungeoneering water.
• Herb Additions:
    • Included Dungeoneering herbs and Juju herbs.
• Legend Guild Basement and Tolna's Rift Spawns:
    • Added spawns in the Legend Guild basement and Tolna's Rift

• NPC Examine Texts:
• Included missing examine texts for NPCs to improve immersion and player interaction.
• TODO for Potions:
• TODO: Document potion recipes and effects in the game's documentation.
• Water Containers:
• Added water containers for emptying and refilling purposes.
• Empty Containers for Unfinished Potions:
• Added empty containers specifically for unfilled potions, facilitating potion-making processes.

Has your code been documented? yes

@MrSlayerGod MrSlayerGod requested a review from a team as a code owner February 16, 2024 13:08
Copy link
Member

@HarleyGilpin HarleyGilpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HerbData enum class needs to be updated to include the required vial item value,

Copy link
Member

@HarleyGilpin HarleyGilpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comment to return potion.requiredVial on line 51 of CreateUnfinishedPotionAction.kt in the canMix function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a check to make sure juju and dungeoneering herbs aren't being used on vials of water.

@HarleyGilpin
Copy link
Member

2011Scape.2024-02-17.15-23-30.mp4

@MrSlayerGod
Copy link
Contributor Author

Java.Mpgyzajyar.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants