-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
juju and dungeoneering potions and water and herbs and spawns and npc examine text and todo for potions #519
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HerbData enum class needs to be updated to include the required vial item value,
.../main/kotlin/gg/rsmod/plugins/content/skills/herblore/mixing/CreateUnfinishedPotionAction.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address comment to return potion.requiredVial on line 51 of CreateUnfinishedPotionAction.kt in the canMix function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a check to make sure juju and dungeoneering herbs aren't being used on vials of water.
2011Scape.2024-02-17.15-23-30.mp4 |
Java.Mpgyzajyar.mp4 |
its inline with other dragonscript comming soon
so we know what dragon script is what aka metal / frost/brutal etc
What has been done?
• NPC Examine Texts:
• Included missing examine texts for NPCs to improve immersion and player interaction.
• TODO for Potions:
• TODO: Document potion recipes and effects in the game's documentation.
• Water Containers:
• Added water containers for emptying and refilling purposes.
• Empty Containers for Unfinished Potions:
• Added empty containers specifically for unfilled potions, facilitating potion-making processes.
Has your code been documented? yes