Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add music functionality #566

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Add music functionality #566

wants to merge 33 commits into from

Conversation

Ilwyd
Copy link
Contributor

@Ilwyd Ilwyd commented Dec 22, 2024

What has been done?

Functionality is mostly complete, I just have some refactoring and commenting to do. Will update once it's ready.

  • Unlocking songs
    • Automatically unlocking default songs (70 total)
    • Send message with song name when unlocking, except when unlocking the default songs
    • Unlocking songs by region
    • Unlocking song by polygon area
      • Implement SimplePolygonArea
      • Implement on_enter_simple_polygon_area plugin
  • Playing songs
    • Changing songs manually
    • Changing songs manually from the playlist
    • Changing to songs when entering a region (was already implemented)
    • Changing to songs when entering a polygon area
  • Playlist functionality
    • Rearranging songs in the playlist
    • Adding songs to the playlist
    • Removing songs from the playlist
    • Add clear playlist button
    • Enabling the playlist
    • Enabling shuffle on the playlist
  • Implement in-packet SoundSongEndMessage
    • Implement on_song_end plugin
    • Automatically change to the next song when the previous one ends, based on playlist / shuffle varbits or the region / area the player is in
  • Add commands
    • Add unlocksong command to unlock specific songs
    • Add resettracks command to re-lock all songs
    • Add unlockallttracks command to unlock all songs

Has your code been documented?

Yes

Ilwyd added 30 commits December 18, 2024 22:57
@Ilwyd Ilwyd marked this pull request as ready for review December 23, 2024 00:23
@Ilwyd Ilwyd requested a review from a team as a code owner December 23, 2024 00:23
@Ilwyd Ilwyd requested a review from DesecratedTree December 23, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant