Add varp and varbit dumps #567
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done?
Asked on discord for people's opinions on this a while back, but didn't get any responses. The idea is to rename the values as we come across the uses for the varps / varbits to better describe what they do. There are many instances in the code where a varbit or varp is set and it's not immediately obvious what is actually being done.
e.g.
VARP_160 -> IMP_CATCHER_STAGE
VARBIT_7079 -> PLAYLIST_ENABLED
Could see something similar being created for the other
DefinitionSetsFeel free to discuss.
Has your code been documented?
Yes