Skip to content

Commit

Permalink
use suffix for main artifacts, clean code of workflows
Browse files Browse the repository at this point in the history
  • Loading branch information
Czaki committed Oct 19, 2024
1 parent 3b0cc0b commit 3aa379a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 17 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/base_test_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ on:
required: false
type: string
default: ""
artifact_suffix:
required: false
type: string
default: ""


jobs:
Expand Down Expand Up @@ -99,7 +103,7 @@ jobs:

- uses: actions/upload-artifact@v4
with:
name: timing-report-${{ inputs.os }}-py-${{ inputs.python_version }}-${{ inputs.napari }}-${{ inputs.qt_backend }}-${{ inputs.coverage }}
name: timing-report-${{ inputs.os }}-py-${{ inputs.python_version }}-${{ inputs.napari }}-${{ inputs.qt_backend }}-${{ inputs.coverage }}${{ inputs.artifact_suffix }}
path: |
./report-*.json
retention-days: 7
Expand All @@ -108,7 +112,7 @@ jobs:
uses: actions/[email protected]
if: ${{ inputs.coverage }}
with:
name: cov-reports-${{ inputs.os }}-py-${{ inputs.python_version }}-${{ inputs.napari }}-${{ inputs.qt_backend }}
name: cov-reports-${{ inputs.os }}-py-${{ inputs.python_version }}-${{ inputs.napari }}-${{ inputs.qt_backend }}${{ inputs.artifact_suffix }}
include-hidden-files: 'true'
path: |
./.coverage.*
16 changes: 1 addition & 15 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,21 +85,6 @@ jobs:
tox_args: ${{ matrix.tox_args }}
pydantic: ${{ matrix.pydantic }}

check_path:
# If steep is pull request then fetch patch and check if file '.github/workflows/test.yml'
# was changed. If it was changed then set 'check' to true.
# If steep is push then set 'check' to true.
name: Check if test.yml was changed
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check if test.yml was changed
id: check
run: echo ::set-output name=check::$(if [ -n "$(git diff --name-only HEAD^ HEAD | grep '.github/workflows/test.yml')" ]; then echo "true"; else echo "false"; fi)
- name: Set check
id: set_check
run: echo ::set-output name=check::${{ steps.check.outputs.check }}

base-test-main:
name: Base py${{ matrix.python_version }}
# if: github.event_name == 'push'
Expand Down Expand Up @@ -140,6 +125,7 @@ jobs:
os: ${{ matrix.os }}
qt_backend: ${{ matrix.qt_backend }}
pydantic: ${{ matrix.pydantic }}
artifact_suffix: "-main"

test_coverage:
needs: download_data
Expand Down

0 comments on commit 3aa379a

Please sign in to comment.