This repository has been archived by the owner on Jul 5, 2020. It is now read-only.
Migration to wicket6 #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add css/js to header response in wicket6 way * Use wicket resource condition for css conditions * Use longs in IDataProvider paging methods * Add extra write method to MergedResourceRequestHandler * Fix tests * Change package imports
|
@zhilvis thanks a million for this pull request! I've created a new branch in the |
|
any good reasons to keep master using 1.5-SNAPSHOT and not 6.X? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I migrated all the code to wicket6. Unit tests are passing.
However I can't give 100% for this code, as I haven't checked it on any project. We are using only shiro module and its working fine.
Hope this will be of any use for you.