Consolidate on pathlib module #306
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 98.15% 98.14% -0.01%
==========================================
Files 11 11
Lines 1028 1024 -4
==========================================
- Hits 1009 1005 -4
Misses 19 19 ☔ View full report in Codecov by Sentry. |
marc-white
changed the title
marc-white
changed the title
charles-turner-1
approved these changes
Dec 11, 2024
|
Running e2e tests needs to wait until #304 is merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #271.
This PR aims to remove
os.pathdependency from the main package, replacing it withpathlib.Path.An e2e test should be done on this branch before merging to confirm the build system is unaffected.
os.pathis still used inversioneer.py, but I think that's code that's been generated externally and committed to our repo, so I haven't touched that.