Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

311 telemetry #312

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

311 telemetry #312

wants to merge 6 commits into from

Conversation

charles-turner-1
Copy link
Collaborator

@charles-turner-1 charles-turner-1 commented Dec 17, 2024

Hooks in telemetry IPython extension upon accessing intake.cat.access_nri - and sends searches performed on either DfFileCatalog objects (ie. the metacatalog), or esm_datastore objects to a telemetry server.

Needs tests (all tests passing, coverage not).

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 42 lines in your changes missing coverage. Please review.

Project coverage is 94.34%. Comparing base (d74943d) to head (940042b).

Files with missing lines Patch % Lines
src/access_nri_intake/data/telemetry.py 17.64% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   98.15%   94.34%   -3.81%     
==========================================
  Files          11       12       +1     
  Lines        1028     1079      +51     
==========================================
+ Hits         1009     1018       +9     
- Misses         19       61      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-turner-1
Copy link
Collaborator Author

Closing this as the testing infrastructure required is too different to the current setup & the functionality can be generalised - it's better off as it's own package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant