Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CICE grid for 0.1 deg ryf with bgc #99

Merged

Conversation

anton-seaice
Copy link
Contributor

Contributes to #92

@anton-seaice anton-seaice marked this pull request as draft April 17, 2024 23:12
@anton-seaice anton-seaice marked this pull request as ready for review April 17, 2024 23:14
aidanheerdegen
aidanheerdegen previously approved these changes Apr 18, 2024
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aidanheerdegen
Copy link
Member

This PR contains a lot of changes that are already in the branch but the commits are different so the rebase merge fails.

Can you please rebase your branch on to the dev- branch and force push.

@anton-seaice anton-seaice force-pushed the update-01deg_jra55_ryf_bgc-iss92 branch from ec0b16a to 3d5fedb Compare April 18, 2024 04:54
@anton-seaice anton-seaice force-pushed the update-01deg_jra55_ryf_bgc-iss92 branch from 3d5fedb to 1727f64 Compare April 18, 2024 04:56
@anton-seaice anton-seaice changed the base branch from dev-01deg_jra55_ryf_bgc to release-01deg_jra55_ryf_bgc April 18, 2024 04:56
@anton-seaice anton-seaice changed the base branch from release-01deg_jra55_ryf_bgc to dev-01deg_jra55_ryf_bgc April 18, 2024 04:57
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@aidanheerdegen aidanheerdegen merged commit 960fc25 into dev-01deg_jra55_ryf_bgc Apr 18, 2024
8 checks passed
@aidanheerdegen aidanheerdegen deleted the update-01deg_jra55_ryf_bgc-iss92 branch April 18, 2024 05:01
@anton-seaice
Copy link
Contributor Author

I'm not sure we quite fixed the problem? i.e. the checksum file is missing?

e.g. dev-01deg_jra55_ryf_bgc...release-01deg_jra55_ryf_bgc shows differences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants