Change woa13 to woa23 #1
Conversation
There was a problem hiding this comment.
Whats the license for this ? Its inhered, so @aekiss - does COSIMA have a preferred license ?
I put some comments on - I haven't run this yet
|
This PR contributes to COSIMA/access-om3#161 |
Co-authored-by: Anton Steketee <[email protected]>
Co-authored-by: Anton Steketee <[email protected]>
Co-authored-by: Anton Steketee <[email protected]>
Co-authored-by: Anton Steketee <[email protected]>
There was a problem hiding this comment.
The general advice is that "months since ..." should be avoided as a time unit. See https://cfconventions.org/Data/cf-conventions/cf-conventions-1.7/build/ch04s04.html
xarray gives me this error, when opening '/g/data/ik11/inputs/access-om3/woa23/monthly/woa23_decav_ts_01_04.nc' :
ValueError: Failed to decode variable 'time': unable to decode time units 'months since 0001-01-01 00:00:00' with 'the default calendar'. Try opening your dataset with decode_times=False or installing cftime if it is not installed.
There is more detailed advice here https://cfconventions.org/Data/cf-conventions/cf-conventions-1.7/build/ch07s04.html but as long as the file opens with xarray I think thats sufficient.
There was a problem hiding this comment.
This script times out for me before finishing
There was a problem hiding this comment.
It works well for me, sometimes it is killed because of overuse of login node. In that case we may have to submit it as a job.
| # to create initial condition files. It combines applies masks | ||
| # to filter invalid data, calculates pressure, absolute salinity, | ||
| # and conservative temperature. | ||
|
|
||
| # import modules | ||
| from glob import glob | ||
| import os,sys |
There was a problem hiding this comment.
| import os,sys | |
| import sys |
| @@ -93,8 +94,7 @@ | |||
| t_conservative = gsw.CT_from_t(s_absolute,t_in_situ,pressure_tile) | |||
|
|
|||
| # save to netcdf | |||
| #save_file = data_dir + 'woa13_decav_ts_jan_04v2.nc' | |||
| save_file = dst_data_dir + 'woa13_decav_ts_'+mon[mm]+'_04v2.nc' | |||
| save_file = dst_data_dir + 'woa23_decav_ts_'+mon[mm]+'_04.nc' | |||
| print(save_file) | |||
There was a problem hiding this comment.
It looks like these 12 'woa23_decav_ts_'+mon[mm]+'_04.nc' files get modified in place to add the time variable and the conservative_temperature, so we need to add metadata for this operation. e.g. what was done, how is practical salinity defined, what code was used, etc
This PR updated all references to WOA2013 to WOA2023 in scripts and documentation.
READMEto reflect WOA2023 references.