-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACCESS-OM3 QA Tests #63
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 78.07% 76.91% -1.17%
==========================================
Files 15 15
Lines 748 771 +23
==========================================
+ Hits 584 593 +9
- Misses 164 178 +14 ☔ View full report in Codecov by Sentry. |
I am not sure if this test is too prescriptive ? e.g. it only looks at this line:
but we might want to configure this quite differently, there are lots of options: |
What types of things are you looking to support, in that case? All of them? Just a subset, for now? Unless I'm reading the docs incorrectly, another way it can be written is:
And then something more confusing with nested timesteps. |
50d377d
to
f12a53b
Compare
f12a53b
to
2c114ba
Compare
I'll be away for the next couple of weeks, so I won't be able to finish this one. Would one of the people in your team be able to continue it, @anton-seaice ? |
In this PR:
Closes #52