Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCESS-OM3 QA Tests #63

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ACCESS-OM3 QA Tests #63

wants to merge 2 commits into from

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Sep 9, 2024

In this PR:

  • test_runconfig_ocn_cpl_dt_equals_runseq_coupling_timestep

Closes #52

@CodeGat CodeGat self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 76.91%. Comparing base (0e91aec) to head (2c114ba).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...rc/model_config_tests/qa/test_access_om3_config.py 40.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   78.07%   76.91%   -1.17%     
==========================================
  Files          15       15              
  Lines         748      771      +23     
==========================================
+ Hits          584      593       +9     
- Misses        164      178      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anton-seaice
Copy link

I am not sure if this test is too prescriptive ?

e.g. it only looks at this line:

@3600

https://github.com/ACCESS-NRI/access-om3-configs/blob/aab066584e21372e6e9546bc661fd395aae441c4/nuopc.runseq#L2

but we might want to configure this quite differently, there are lots of options:

https://earthsystemmodeling.org/docs/release/ESMF_8_3_1/NUOPC_refdoc/node4.html#SECTION000411300000000000000

@CodeGat
Copy link
Collaborator Author

CodeGat commented Oct 17, 2024

What types of things are you looking to support, in that case? All of them? Just a subset, for now? Unless I'm reading the docs incorrectly, another way it can be written is:

@timeStep:runDuration
# @123:4000

And then something more confusing with nested timesteps.

@CodeGat CodeGat force-pushed the 52-om3-qa-checks branch 2 times, most recently from 50d377d to f12a53b Compare October 17, 2024 05:25
@CodeGat CodeGat added priority:high type:qa-check Quality Assurance Checks labels Oct 18, 2024
@CodeGat
Copy link
Collaborator Author

CodeGat commented Oct 30, 2024

I'll be away for the next couple of weeks, so I won't be able to finish this one. Would one of the people in your team be able to continue it, @anton-seaice ?
If it is eventually merged, one will have to update the config/ci.ymls model-config-tests-version section in access-om3-configs to 0.0.9.

@CodeGat CodeGat removed their assignment Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high type:qa-check Quality Assurance Checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACCESS-OM3 QA checks
2 participants