Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cice5 package.py #8

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Update cice5 package.py #8

merged 4 commits into from
Mar 30, 2023

Conversation

harshula
Copy link
Collaborator

No description provided.

@harshula harshula self-assigned this Mar 14, 2023
@harshula harshula mentioned this pull request Mar 14, 2023
Closed
aidanheerdegen
aidanheerdegen reviewed Mar 15, 2023
View reviewed changes
packages/cice5/0001-Revert-Fix-Error-Period-required-in-format-specifier-E.patch Outdated Show resolved Hide resolved
packages/cice5/package.py Show resolved Hide resolved
packages/cice5/package.py Outdated Show resolved Hide resolved
packages/cice5/package.py Outdated Show resolved Hide resolved
packages/cice5/package.py Outdated Show resolved Hide resolved
packages/cice5/package.py Show resolved Hide resolved
@harshula
Copy link
Collaborator Author

harshula commented Mar 26, 2023 •
edited
Loading

The following changes to cice5 are a pre-requisite before merge: ACCESS-NRI/cice5#5

harshula added 4 commits March 29, 2023 22:27
@harshula
cice5: draft Spack package file
b452fce 
* NOTE: The order of the libraries matter during the linking step!
* NOTE: datetime-fortran is a dependency of libaccessom2.
@harshula
cice5: use a version of parallelio with variant "shared"
ab2d5e9 
* Requires: spack/spack#34837
@harshula
cice5: support building with the Intel compiler
5aaf19e 
* copy cice5's bld/build.sh as a template to build from spack
@harshula
cice5: change branch dependency from "spack-build" to "master" for merge
02be463 
* #8
@harshula
Copy link
Collaborator Author

Ready for Review!

@harshula harshula requested a review from aidanheerdegen March 29, 2023 11:40
@harshula harshula marked this pull request as ready for review March 29, 2023 11:43
@harshula
Copy link
Collaborator Author

NOTE: The easiest way to review https://github.com/ACCESS-NRI/spack_packages/blob/cice5/packages/cice5/spack-build.sh is to do a graphical diff against https://github.com/ACCESS-NRI/cice5/blob/master/bld/build.sh

@harshula
Copy link
Collaborator Author

NOTE 2: There is an additional patch "cice5: simplify build script and Makefile snippet" that I'll commit to the development branch once this PR is merged. W.R.T. spack-build.sh, please focus on detecting any bugs during the review and please do not spend time on how to improve it. Save that for the review of the aforementioned patch.

aidanheerdegen
aidanheerdegen approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the logic and the specific numbers of the 722 case and they look fine. I can check the other NTASK configs if you want a sanity check.

Otherwise looks good and I'm happy to merge.

@harshula
Copy link
Collaborator Author

I can check the other NTASK configs if you want a sanity check.

Yes, please.

@aidanheerdegen
Copy link
Member

All checked and seem fine.

@harshula harshula merged commit 1137561 into main Mar 30, 2023
@harshula harshula deleted the cice5 branch March 30, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

@echus echus Awaiting requested review from echus

Assignees

@harshula harshula

Labels
None yet
Projects
ACCESS-OM2 Spack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshula @aidanheerdegen