Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add participant-<mishra-aanchal> #39

Closed
wants to merge 1 commit into from
Closed

add participant-<mishra-aanchal> #39

wants to merge 1 commit into from

Conversation

mishra-aanchal
Copy link

@mishra-aanchal mishra-aanchal commented Apr 14, 2020

For #20

Copy link
Member

@lisa761 lisa761 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @mishra-aanchal You haven't added the necessary information that was asked to be added. Please add them and push the commit again.

@lisa761
Copy link
Member

lisa761 commented Apr 14, 2020

Hi @mishra-aanchal, The Task-2 asks you to create a new file and these information there. The changes are not supposed to be made to demo.md like in the screen shot you shared. In this PR, you seem to have successfully added the file. Are you still unable to make changes to do that file and save it?

@mishra-aanchal
Copy link
Author

mishra-aanchal commented Apr 15, 2020

Hi, @mishra-aanchal You haven't added the necessary information that was asked to be added. Please add them and push the commit again.

hello @lisa761 i guess i added the information my name, university, branch and year from the Notepad.

@mishra-aanchal
Copy link
Author

Hi @mishra-aanchal, The Task-2 asks you to create a new file and these information there. The changes are not supposed to be made to demo.md like in the screen shot you shared. In this PR, you seem to have successfully added the file. Are you still unable to make changes to do that file and save it?

yes i was able to!
thankyou.

@lisa761
Copy link
Member

lisa761 commented Apr 15, 2020

So you will need to add the info in your file and then we can merge this PR. Currently, that file is empty.

@lisa761
Copy link
Member

lisa761 commented Apr 16, 2020

Hi @mishra-aanchal, if you need any help, feel free to ask.

@mishra-aanchal
Copy link
Author

mishra-aanchal commented Apr 16, 2020 via email

@lisa761
Copy link
Member

lisa761 commented Apr 16, 2020

Hi, @mishra-aanchal here is the link to reset your master. Make sure that you do this before creating another PR.

@soumyaa1804
Copy link
Member

@mishra-aanchal, as @lisa761 said you first need to reset your master then it would be great if you do task 3 again. It won't be useful to commit to the same branch now.

@soumyaa1804
Copy link
Member

Closing this one as a new PR is expected. Feel free to open in case of any discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants