Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling md omkaragrawal #75

Closed
wants to merge 4 commits into from
Closed

Styling md omkaragrawal #75

wants to merge 4 commits into from

Conversation

Omkaragrawal
Copy link
Contributor

@Omkaragrawal Omkaragrawal commented Apr 15, 2020

image

For #50

ImgBotApp and others added 4 commits April 13, 2020 18:59
*Total -- 2,029.62kb -> 1,854.36kb (8.64%)

/public/img/2020-04-09 (2).png -- 12.57kb -> 5.02kb (60.07%)
/public/img/Untitled Document (1).png -- 200.52kb -> 98.54kb (50.86%)
/public/img/competitive/comp1.jpg -- 199.70kb -> 179.34kb (10.2%)
/public/img/dipux/ux1.png -- 166.06kb -> 158.86kb (4.33%)
/public/img/Poster.jpeg -- 343.57kb -> 331.16kb (3.61%)
/public/img/participants-images/Poster.jpeg -- 343.57kb -> 331.16kb (3.61%)
/public/img/bot/bot1.png -- 118.96kb -> 115.07kb (3.27%)
/public/img/python/py1.png -- 44.72kb -> 43.83kb (1.97%)
/public/img/dipux/dip1.jpg -- 177.87kb -> 174.54kb (1.88%)
/public/img/2019/recruitment.png -- 43.71kb -> 42.99kb (1.66%)
/public/img/2019/design.png -- 130.98kb -> 128.90kb (1.59%)
/public/img/android/and1.png -- 194.81kb -> 192.42kb (1.23%)
/public/img/2019/drone.jpg -- 26.10kb -> 26.07kb (0.1%)
/public/img/2019/android.jpg -- 26.49kb -> 26.46kb (0.1%)

Signed-off-by: ImgBotApp <[email protected]>
@soumyaa1804
Copy link
Member

@Omkaragrawal, you have added the wrong origin repository. I just noticed your origin is https://github.com/omkaragrawal/Open-Source-Challenge.git instead of https://github.com/Omkaragrawal/Open-Source-Challenge.git. Notice the capital O in Omkaragrawal. You can see here.

@soumyaa1804
Copy link
Member

soumyaa1804 commented Apr 15, 2020

Also, you have committed to master which you should not do at all. Please update your origin and reset your master.

@Omkaragrawal
Copy link
Contributor Author

@soumyaa1804 I believe, even though a mistake, it did come in sync with the proper git repo of "Omkaragarawal". The image below would clear out things for you. Also the push command was given in VSCode's integrated terminal, and I forgot to take a screenshot of it. Nonetheless my PR request should be correct. Please have a look once again, and if wrong, can you please point out the exact mistake. that would be a great help.

image

@lisa761
Copy link
Member

lisa761 commented Apr 15, 2020

Hi @Omkaragrawal, since you have made a successful submission of Task-2 I am guessing somehow your origin is correct. But you seem to have merged a PR in your forked repo from ImgBot used to decrease the size of the images. Since this was an unnecessary change, it adds a lot of unrelated commits to this PR as you can see here itself. I would suggest resetting your master using the upstream by following this step by step and creating a new PR with a different branch. Try to avoid merging anything or adding any commits to your master branch.

@soumyaa1804
Copy link
Member

soumyaa1804 commented Apr 15, 2020

As you can see in the files changed tab on this page, you have 15 changed files. A successful submission would require only one file change.

@Omkaragrawal Omkaragrawal deleted the styling-md-omkaragrawal branch April 15, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants