Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

styling-Tanisha #87

Merged
merged 4 commits into from
Apr 17, 2020
Merged

styling-Tanisha #87

merged 4 commits into from
Apr 17, 2020

Conversation

Tanisha07
Copy link
Contributor

@Tanisha07 Tanisha07 commented Apr 15, 2020 •
edited by lisa761
Loading

For #50

lisa761
lisa761 reviewed Apr 16, 2020
View reviewed changes
Copy link
Member

@lisa761 lisa761 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is your submission for task 2, I am okay with merging this as it is, as its completely unrelated to styling. So tell us if you are done and we will merge this.

participants/Tanisha07.md Outdated Show resolved Hide resolved
@lisa761
Copy link
Member

lisa761 commented Apr 17, 2020

Hi @Tanisha07, Do you think perhaps, that your PR should be named differently? Anyone can mistake it for a submission of Task-2, but I rechecked and you have already given a successful submission for it. Please take care of this next time.

@lisa761 lisa761 changed the title add participant-Tanisha styling-Tanisha Apr 17, 2020
@lisa761 lisa761 merged commit 9fbaf93 into ACM-IGDTUW:master Apr 17, 2020
@Tanisha07
Copy link
Contributor Author

Hi @lisa761. Thanks for informing. I'll be more careful in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisa761 lisa761 lisa761 approved these changes

Assignees
No one assigned
Labels
For Task-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tanisha07 @lisa761