Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add participant-vanshika #90

Closed
wants to merge 1 commit into from

Conversation

vkr-code
Copy link
Contributor

@vkr-code vkr-code commented Apr 16, 2020

Pls suggest changes..
For #50

@soumyaa1804
Copy link
Member

@vkr-code The changes look great but can you make changes to only the file you created in task 2 and delete this file? Your previous file would be vkr-code.md in the participants directory.

@vkr-code
Copy link
Contributor Author

vkr-code commented Apr 16, 2020 via email

@lisa761
Copy link
Member

lisa761 commented Apr 16, 2020

Hi @vkr-code, just a suggestion, name your PRs in a more appropriate way. For eg, this PR is for Task-3, but your title is the same as that you used for submission of Task-2. You could, for example, name this one as Styling vkr-code.md.

@vkr-code
Copy link
Contributor Author

vkr-code commented Apr 16, 2020 via email

@lisa761
Copy link
Member

lisa761 commented May 7, 2020

Closing this since it has been inactive for a while now. Feel free to reopen in case you want to continue working on this.

@lisa761 lisa761 closed this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants