Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update last found time when evaluating an input #2782

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

celi0n
Copy link
Contributor

@celi0n celi0n commented Dec 18, 2024

When trying to use the last_found_time member of state, I found that it is only updated in the function add_input.
In my case, I was using fuzzer.fuzz_one and add_input was never called during fuzzing.

This looks like a bug as the description of this field is The last time we found something by ourselves.

In this fix I added 3 lines to update last_found_time when an interesting input is found in evaluate_execution.

@domenukk
Copy link
Member

When/why would an interesting input not be added in your case?

@celi0n
Copy link
Contributor Author

celi0n commented Dec 19, 2024

I have no idea, this merge request has nothing to do with how interesting is an input. The code change only update last_found_time which is not used in forkserver_libafl_cc. Maybe it is an issue with the test, or the code I merge from ?

@domenukk domenukk requested a review from tokatoka December 19, 2024 09:07
@tokatoka
Copy link
Member

lgtm

@domenukk domenukk merged commit 09950cc into AFLplusplus:main Dec 19, 2024
102 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants