imemory_ondisk: Don't fail write under any circumstances if locking is disabled #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
Dec 24, 2024
libafl/src/corpus/inmemory_ondisk.rs
Outdated
| } | ||
| } else if let Err(error) = self.store_input_from(testcase) { | ||
| log::error!( | ||
| "An error occurred when trying to write a testcase without locking: {}", |
There was a problem hiding this comment.
This is like a format string, right? So we can do
"An error occurred when trying to write a testcase without locking: {err}",
There was a problem hiding this comment.
Micro optimization, but the whole thing could be
if let Err(err) = self.store_input_from(testcase) {
if self.locking {
return Err(err);
}
log::error!("An error occurred when trying to write a testcase without locking: {err}",
}then you only need to check the extra condition in the error case
domenukk
approved these changes
Dec 24, 2024
|
Feel free to merge. As stated elsewhere, #2434 would be the proper fix, though :) |
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Dec 24, 2024
…s disabled (AFLplusplus#2791) * imemory_ondisk: Don't fail write under any circumstances if locking is disabled * fmt * inmemory_ondisk: Add a log message on failure * clippy' * micro optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary if you want to disable locking for a corpus.