Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frida: Deduplicate with IfElseRuntime #2792

Merged
merged 11 commits into from
Dec 25, 2024
Merged

Conversation

s1341
Copy link
Collaborator

@s1341 s1341 commented Dec 24, 2024

No description provided.

@s1341 s1341 merged commit 2a79ee5 into main Dec 25, 2024
100 checks passed
@s1341 s1341 deleted the frida_deduplicate_with_IfElseRuntime branch December 25, 2024 12:42
@@ -593,7 +593,7 @@ impl AsanRuntime {

let _ = [<$lib_ident:snake:upper _ $name:snake:upper _PTR>].set(unsafe {std::mem::transmute::<*const c_void, extern "C" fn($($param: $param_type),*) -> $return_type>(target_function.0)}).unwrap_or_else(|e| println!("{:?}", e));

#[expect(non_snake_case)]
#[allow(non_snake_case)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not expect?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because its a macro and not all use cases are non_snake_case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants