Lint everything #257
Draft
Lint everything #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrc-benmorrow
force-pushed
the
bmz/lint-all
branch
3 times, most recently
from
c709267 to
3945a43
Compare
amrc-benmorrow
force-pushed
the
bmz/lint-all
branch
from
3945a43 to
ecb7a89
Compare
Most of these do nothing as yet, but this gives us a framework. Create a recursive top-level Makefile.
Give the recursive targets do-nothing commands. All deps of these targets must now use unique target names. (We could use :: targets instead, but this doesn't give order to the chunks of rule.) Refactor the recursion.
Annoyingly we seem to need to install this separately for each subdir, because of the way Node works.
The GH Actions checkout doesn't normally include tags or history, presumably for speed. We don't care for linting, but we don't need errors. GMake likes to print a lot of messages about entering and leaving directories, which are not helpful here.
amrc-benmorrow
force-pushed
the
bmz/lint-all
branch
from
ecb7a89 to
282d40f
Compare
|
This needs rebasing before it can be considered for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make linttop-level Makefile target which runs through all subdirs and lints anything which defines a lint rule.deploysubdir.