Enforce schema validation on pre-commit. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you're on GH.com you could run this as an Action on any PRs? It wouldn't let you merge invalid branches then |
|
@Kallb123 Yes, maybe... I find GH actions annoying to set up :). I think we'd want to leave it as a |
|
It is pretty wasteful to push and then find it's failed. How do you actually distribute or enforce a client-side hook though? Since they're not in the repo, do you share it separately? |
|
OK, I'm being stupid; I hadn't realised this hadn't committed the |
An explicit setup step is required, to prevent remote code execution.
|
Github Action added. |
added 2 commits
November 8, 2023 11:59
AlexGodbehere
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are wasting too much time committing invalid schemas. Set up a pre-commit hook which enforces validity.