Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DC Circuit v1 #35

Merged
merged 1 commit into from
Nov 22, 2023
Merged

DC Circuit v1 #35

merged 1 commit into from
Nov 22, 2023

Conversation

grigals
Copy link
Contributor

@grigals grigals commented Nov 22, 2023 •
edited
Loading

V1 for Direct circuit schema.

@grigals grigals marked this pull request as ready for review November 22, 2023 09:16
AlexGodbehere
AlexGodbehere approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@AlexGodbehere AlexGodbehere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should have gone with Voltage and Current instead of Voltage_DC and Current_DC but we've used that convention in Phase-v2 so let's stick with it.

@grigals grigals merged commit e9aa4e1 into main Nov 22, 2023
1 check passed
@grigals grigals deleted the feature/energy-monitoring-dc branch November 22, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexGodbehere AlexGodbehere AlexGodbehere approved these changes

@amrc-benmorrow amrc-benmorrow Awaiting requested review from amrc-benmorrow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grigals @AlexGodbehere