Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing basic classes
This pull request includes several changes to improve the AR.js core library, including updates to dependencies, class structures, and configuration files. The most important changes are grouped by theme below.
Dependency and Configuration Updates:
main
field inpackage.json
to referencedist/ARjs-core.js
instead ofdist/ar-core.js
.devDependencies
and addedworker-loader
todevDependencies
inpackage.json
.Class and Method Updates:
baseUrl
tobaseURL
and added anaddEventListener
method in theContext
class insrc/arjs-context.js
. [1] [2]ArBaseControls
class insrc/threex-arbasecontrols.js
and extended it inArSmoothedControls
class insrc/threex-arsmoothedcontrols.js
. [1] [2]Anchor
class insrc/new-api/arjs-anchor.js
.Worker and Session Management:
src/arjs-markercontrols-nft.worker.js
.three
and removed sanity checks in theSession
class insrc/new-api/arjs-session.js
. [1] [2]Webpack Configuration:
ARjsCore
and added a rule for handling worker files inwebpack.config.js
. [1] [2]I will try to implement the basic core classes without three.js to be imported in system-arjs.js (Aframe)