-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapted to the latest version of Transformer (Fixes #13245) #16622
Conversation
OK. |
also
the transformers code you link is 4.47.0.dev0 but we are using transformers==4.30.2
so you shoud be looking at but regardless of 4.47.0.dev0 or 4.30.2 docstring says both says
which contradicts what you said so you need to provide more information |
Thanks!
You are right, sorry. |
but the thing is it's working without it for most people it's like what's happening on your system that is cause the issue like Auto said in the other PR
so if you can actually figure out what is causing the bug and provide a fix reason for it then sure |
Ok, you're right. I'll reopen it if I can find the root cause. Thank you! |
Interesting, because the fix actually works. Not only does it allow us to use an updated working version of transformers, it also finally allows us to use an updated version of tokenizers, and thus make Automatic1111 compatible with Python 3.12 (only with some others package updates). I've been testing the environment for days now, and haven't found a single bug for now Win11, Python 3.12.7, pyTorch 2.5.1 + cu12.4 + cudnn 9.5.1, xformers 0.0.28.post3 |
Description
This fixes #13245, there is a patch but not reported.
See also the calling function (First argument can not be None any more):
https://github.com/huggingface/transformers/blob/33868a057c02f0368ba63bd1edb746be38fe3d90/src/transformers/modeling_utils.py#L3179-L3440
Checklist: