Fix variable inconsistencies, Closes #9

Aasim-A · Dec 19, 2021 · ba34024 · ba34024
1 parent 432c33b
commit ba34024
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1 @@
+/.vscode
diff --git a/library.json b/library.json
@@ -1,6 +1,6 @@
 {
   "name": "AsyncTimer",
-  "version": "2.1.2",
+  "version": "2.1.3",
   "description": "JavaScript-like async timing functions (setTimeout, setInterval).",
   "keywords": [
     "settimeout",

diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=AsyncTimer
-version=2.1.2
+version=2.1.3
 author=Aasim-A
 maintainer=Aasim-A <github.com/Aasim-A>
 sentence=JavaScript-like async timing functions (setTimeout, setInterval).

diff --git a/src/AsyncTimer.cpp b/src/AsyncTimer.cpp
@@ -30,25 +30,25 @@ unsigned short AsyncTimer::setInterval(void (*callback)(), unsigned long ms) {
 }
 
 void AsyncTimer::changeDelay(unsigned short id, unsigned long ms) {
-  for (short i = 0; i < m_maxArrayLength; i++)
+  for (unsigned short i = 0; i < m_maxArrayLength; i++)
     if (m_callsArray[i].id == id)
       m_callsArray[i].delayByMs = ms;
 }
 
 void AsyncTimer::delay(unsigned short id, unsigned long ms) {
-  for (short i = 0; i < m_maxArrayLength; i++)
+  for (unsigned short i = 0; i < m_maxArrayLength; i++)
     if (m_callsArray[i].id == id)
       m_callsArray[i].timestamp += ms;
 }
 
 void AsyncTimer::reset(unsigned short id) {
-  for (short i = 0; i < m_maxArrayLength; i++)
+  for (unsigned short i = 0; i < m_maxArrayLength; i++)
     if (m_callsArray[i].id == id)
       m_callsArray[i].timestamp = millis();
 }
 
 void AsyncTimer::cancel(unsigned short id) {
-  for (short i = 0; i < m_maxArrayLength; i++) {
+  for (unsigned short i = 0; i < m_maxArrayLength; i++) {
     if (m_callsArray[i].id == id && m_callsArray[i].active) {
       m_callsArray[i].active = false;
       m_arrayLength--;
@@ -62,7 +62,7 @@ void AsyncTimer::handle() {
   if (m_arrayLength == 0)
     return;
 
-  for (short i = 0; i < m_maxArrayLength; i++) {
+  for (unsigned short i = 0; i < m_maxArrayLength; i++) {
     unsigned long timestamp = millis();
     if (!m_callsArray[i].active || m_callsArray[i].timestamp > timestamp)
       continue;

diff --git a/src/AsyncTimer.h b/src/AsyncTimer.h
@@ -53,7 +53,7 @@ class AsyncTimer {
     m_callsArray = new m_TimerInfo[arrayLength];
     m_availableIndicesLength = arrayLength;
     m_availableIndices = new unsigned short[arrayLength];
-    for (short i = 0; i < m_availableIndicesLength; i++)
+    for (unsigned short i = 0; i < m_availableIndicesLength; i++)
       m_availableIndices[i] = i;
   }
   ~AsyncTimer() {