Branches - Michaela #38

michaela260 · 2019-09-09T12:22:55Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	It was really challenging to know how to structure blocks vs. reservations and whether one should be a subclass of the other. It was also challenging to not let my classes have too many dependencies.
What was a design decision you made that changed over time over the project?	Originally I thought the room class would hold info about its cost, but I changed that because the same room can have different costs depending on block status.
What was a concept you gained clarity on, or a learning that you'd like to share?	I'm much more comfortable using keyword and optional arguments now; it was helpful for some parameters to have default values. I also feel more confident about writing tests - I'm proud of the 100% coverage!
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	A nominal test was that the 'make_reservation' method creates a new instance of Reservation. It's nominal, because it should always be true and relevant whenever any reservation is created.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	An edge case test for 'make_reservation' was that it raises an ArgumentError if no rooms are available. This is an edge case because it's a more rare scenario and has a different outcome than usual.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	At first, I did this really well, up through wave 2. Then in wave 3 I mostly wrote the code first unfortunately.

…e of Room

…verlap?' method

…d arguments

… on the given date

…s that end on the given date

…mber' are included as parameters and are no longer randomly assigned

…nd 'list_of_reservations_by_date'

…ed 'find_room', 'find_reservation', and 'list_of_available_rooms_by_date' methods

…able rooms; also added tests for 'list_of_available_rooms_by_date', 'find_room', and 'find_reservation' methods

… with blocks

…ions

tildeee · 2019-09-17T21:47:32Z

Hotel

What We're Looking For

Test Inspection

Workflow	yes / yes but no test / no
Wave 1
List rooms	yes
Reserve a room for a given date range	yes
Reserve a room (edge case)	yes
List reservations for a given date	yes
Calculate reservation price	yes
Invalid date range produces an error	yes
Test coverage	yes
Wave 2
View available rooms for a given date range	yes
Reserving a room that is not available produces an error	yes
Test coverage	yes
Wave 3
Create a block of rooms	yes
Check if a block has rooms	yes
Reserve a room from a block	yes
Test coverage	yes

Code Review

Baseline	Feedback
Used git regularly	yes
Answer comprehension questions	yes
Design
Each class is responsible for a single piece of the program	yes
Classes are loosely coupled	yes
Fundamentals
Names variables, classes and modules appropriately	yes
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	yes
Appropriately uses methods to break down tasks into smaller simpler tasks	yes
Understands the differences between class and instance methods	yes
Appropriately uses iterators and `Enumerable` methods	yes
Appropriately writes and utilizes classes	yes
Appropriately utilizes modules as a namespace	yes
Wrap Up
There is a refactors.txt file	yes
The file provides a roadmap to future changes	yes

Overall Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

Your code is well-written! I think that your tests are well-written and cover all of the cases with all of the appropriate details. Your tests are really a great standard! Your implementation is also clean and logical and has elegant code style. A lot of your design is really thoughtful; from the big ideas of classes and their coupling, to also the details like optional arguments. Really great work!

I've found some areas in which I could imagine you to refactor if you had more time in this project... a lot of these are small areas that I think could be more concise; they're generally minor suggestions.

Overall, you did a great job on this! Great work!

tildeee · 2019-09-17T21:48:06Z

lib/manager.rb

+        raise ArgumentError.new "Error! You entered an invalid room number: #{room_number_to_search}"
+      end
+
+      return @list_of_all_rooms.find { |room| room.room_number == room_number_to_search }


Nice! This whole method is perfect!

tildeee · 2019-09-17T21:48:26Z

lib/manager.rb

+        raise ArgumentError.new "Error! You entered an invalid reservation number: #{reservation_number_to_search}"
+      end
+
+      return @list_of_all_reservations.find { |reservation| reservation.reservation_number == reservation_number_to_search}


Hm, I think that this method could be refactored to not use indicator, but to utilize what .find does if no match is found.

tildeee · 2019-09-17T21:48:52Z

lib/manager.rb

+
+    def list_of_available_rooms_by_date(date_to_check: )
+      unavailable_room_numbers = list_of_reservations_by_date(date_to_search: date_to_check).map do |reservation|
+        reservation.room_number


the code in this method looks good-- It may be interesting to see if Reservations can reference Rooms so that getting the instance of Room doesn't take so much work heh, or refactor the below loops so that that finding the available rooms doesn't take so much work. (I don't have any suggestions right now, sorry :) )

tildeee · 2019-09-17T21:49:05Z

test/block_test.rb

+      end
+    end
+
+    it "raises an ArgumentError if given an invalid collection of room numbers" do


This is great!

tildeee · 2019-09-17T21:49:45Z

lib/date_range.rb

+        return true
+      else
+        return false
+      end


Minor: Consider refactoring syntax like this to:

return date >= @start_date && date < @end_date

tildeee · 2019-09-17T21:50:20Z

lib/manager.rb

+        return false
+      else
+        return true
+      end


Minor: Consider refactoring this to:

return !possible_room_numbers.empty?

… utilize it in Manager class

michaela260 added 30 commits September 3, 2019 14:57

Added SimpleCov and added require_relative for my lib files

6395960

Created unit tests for Hotel::Room class

25ba853

Created Hotel::Room class

60494d8

Moved simplecov require statement to the top of the file

cbfce2e

Added a unit test for Room class to check that it makes a new instanc…

66fd8ed

…e of Room

Created unit tests for DateRange class

fffda25

created DateRange class and defined method 'overlap?'

bd9d5dc

Corrected tests and methods to verify valid input date_range_2 for 'o…

68e5afa

…verlap?' method

Changed 'initialize' parameters 'start_date' and 'end_date' to keywor…

5c6eb5f

…d arguments

Added unit tests for date_range_includes method for date_range class

d69b367

Defined method 'date_range_includes?' for date_range class

eb64ef0

Added more unit tests for 'date_range_includes?' method

a39ca9c

Added unit test for 'number_of_nights' method

ba100f8

Defined method 'number_of_nights'

51025de

Edited number_of_nights method

8348468

Created unit tests for Reservation class

af35ae5

Created Reservation class

ccf69d4

Edited 'date_range_includes?' method to exclude reservations that end…

99a357b

… on the given date

Updated unit tests for 'date_range_includes?' method to exclude range…

f731673

…s that end on the given date

Updated 'initialize' method so that 'room_number' and 'reservation_nu…

6f9a696

…mber' are included as parameters and are no longer randomly assigned

Removed 'cost' attribute from 'initialize' method

466c553

Created unit tests for Hotel::Manager class

eb929f2

Created Hotel::Manager class and defined methods 'make_reservation' a…

715fdb7

…nd 'list_of_reservations_by_date'

Updated 'make_reservation' method to assign only available rooms; add…

d9d6142

…ed 'find_room', 'find_reservation', and 'list_of_available_rooms_by_date' methods

Updated unit tests to check that reservations are only made for avail…

0606291

…able rooms; also added tests for 'list_of_available_rooms_by_date', 'find_room', and 'find_reservation' methods

Removed pseudocode

8e54eb8

Created unit tests for Hotel::Block class

f8c2d40

Defined class 'Hotel::Block

fcf13f7

Changed 'cost_per_night_ attribute so that it can be adjusted by user…

d687b61

… with blocks

Added methods and unit tests for creating and managing block reservat…

138ee08

…ions

michaela260 added 2 commits September 9, 2019 05:07

Added ds store

e2cba6a

Wrote possible refactoring ideas

0a48392

tildeee reviewed Sep 17, 2019

View reviewed changes

test/block_test.rb

end

end

it "raises an ArgumentError if given an invalid collection of room numbers" do

Copy link

tildeee Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

tildeee reviewed Sep 17, 2019

View reviewed changes

lib/manager.rb

return false

else

return true

end

Copy link

tildeee Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Consider refactoring this to:

return !possible_room_numbers.empty?

michaela260 added 3 commits September 25, 2019 18:54

Answered design activity questions

86f9ae1

Added idea for refactoring

52e0d77

Refactored to define 'includes_date?' method in Reservation class and…

9117ea1

… utilize it in Manager class

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Branches - Michaela #38

Branches - Michaela #38

michaela260 commented Sep 9, 2019

tildeee commented Sep 17, 2019

tildeee Sep 17, 2019

tildeee Sep 17, 2019

tildeee Sep 17, 2019

tildeee Sep 17, 2019

tildeee Sep 17, 2019

tildeee Sep 17, 2019

Branches - Michaela #38

Are you sure you want to change the base?

Branches - Michaela #38

Conversation

michaela260 commented Sep 9, 2019

Hotel

Comprehension Questions

tildeee commented Sep 17, 2019

Hotel

What We're Looking For

Test Inspection

Code Review

Overall Feedback

tildeee Sep 17, 2019

Choose a reason for hiding this comment

tildeee Sep 17, 2019

Choose a reason for hiding this comment

tildeee Sep 17, 2019

Choose a reason for hiding this comment

tildeee Sep 17, 2019

Choose a reason for hiding this comment

tildeee Sep 17, 2019

Choose a reason for hiding this comment

tildeee Sep 17, 2019

Choose a reason for hiding this comment