Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for section about rules priorities #258

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

105th
Copy link
Member

@105th 105th commented Aug 1, 2023

A few corrections to fix arithmetic errors and clarify some non-standard situations

@105th 105th requested review from ngorskikh and el-termikael August 1, 2023 20:55
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
@105th 105th requested review from el-termikael and sfionov August 2, 2023 10:04
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved

**Example 7**

`@@||example.org^$document` without additional modifiers is an alias for
`@@||example.org^$document` is an alias for
`@@||example.com^$elemhide,content,jsinject,urlblock,extension`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Теперь как раз надо разделить этот пример на два, эти правила не эквивалентны)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngorskikh почему не эквивалентны?
вот выдержка из документации:

If this modifier is used with an exclusion rule (@@), it completely disables blocking on corresponding pages. It is equivalent to using $elemhide, $content, $urlblock, $jsinject, $extension modifiers simultaneously

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfionov Вызываю поддержку с воздуха. В корлибсах нынче эти два правила не эквивалентны: из-за того, что в них нет модификаторов типа запроса, применяются некие типа запроса по-умолчанию (это было сделано не просто так, а по чьему-то строгому указанию, не помню, чьему):
@@||example.com^$elemhide,content,jsinject,urlblock,extension неявно содержит два типа запроса: DOCUMENT и SUBDOCUMENT. @@||example.org^$document неявно содержит только тип запроса DOCUMENT. Следовательно, приоритеты у них вычисляются разные. Кто прав, кто виноват, нипонятно :(

docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants