Skip to content

Commit

Permalink
Fix corrupted file after signing
Browse files Browse the repository at this point in the history
Merge in EXTENSIONS/go-webext from fix/sign to master

Squashed commit of the following:

commit e225bae
Author: Maxim Topciu <[email protected]>
Date:   Thu Oct 19 16:05:51 2023 +0300

    update changelog

commit 0d88de5
Author: Maxim Topciu <[email protected]>
Date:   Thu Oct 19 16:02:56 2023 +0300

    increase read limit for chrome as well

commit a6a9ab2
Author: Maxim Topciu <[email protected]>
Date:   Thu Oct 19 16:01:05 2023 +0300

    increase maxReadLimit
  • Loading branch information
maximtop committed Oct 19, 2023
1 parent 82a0295 commit f5e0823
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# go-webext changelog

## 0.1.2 (2023-10-19)

### Changed
- Fix downloading signed xpi file.

## 0.1.1 (2023-10-10)

### Changed
Expand Down
3 changes: 2 additions & 1 deletion internal/chrome/chrome.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ type Client struct {
RefreshToken string
}

// TODO make configurable
// maxReadLimit limits response size returned from the store.
const maxReadLimit = 10 * fileutil.MB
const maxReadLimit = 100 * fileutil.MB

// AuthorizeResponse describes the response received from the Chrome Store
// authorization request.
Expand Down
3 changes: 2 additions & 1 deletion internal/firefox/api/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ import (
// TODO (maximtop): consider to make this constant an option.
const requestTimeout = 20 * time.Minute

// TODO make configurable
// maxReadLimit limits response size returned from the store api.
const maxReadLimit = 10 * fileutil.MB
const maxReadLimit = 100 * fileutil.MB

// DefaultExtensionFilename is the default filename for the extension zip file to be
// uploaded.
Expand Down

0 comments on commit f5e0823

Please sign in to comment.