Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance]: eliminate-overwriting code #2381

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from

Conversation

ashrafchowdury
Copy link
Collaborator

@ashrafchowdury ashrafchowdury commented Dec 18, 2024

Description

This PR aims to fix the overwriting code in cloud_dev to provide a consistent dev experience.

Related Issue

Closes AGE-1479

Related PR

https://github.com/Agenta-AI/agenta_cloud/pull/533/files

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 10:12am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 10:12am

@ashrafchowdury ashrafchowdury marked this pull request as ready for review December 24, 2024 11:11
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 24, 2024
@dosubot dosubot bot added dev experience Improvement of the experience using the software. For instance better error messaging nextjs labels Dec 24, 2024
@ashrafchowdury
Copy link
Collaborator Author

This is not a very good way to fix the issue, but for a hot-fix I guess this may work

cy.wait(2000)

Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small notes @ashrafchowdury

Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we have added another is setState. let's just utilize the state value we already have instead of a new one

agenta-web/src/components/Scripts/GlobalScripts.tsx Outdated Show resolved Hide resolved
agenta-web/src/components/Scripts/GlobalScripts.tsx Outdated Show resolved Hide resolved
agenta-web/src/components/Scripts/GlobalScripts.tsx Outdated Show resolved Hide resolved
agenta-web/src/components/Scripts/GlobalScripts.tsx Outdated Show resolved Hide resolved
agenta-web/src/components/Scripts/GlobalScripts.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🙏 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev experience Improvement of the experience using the software. For instance better error messaging nextjs size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants