Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user to AliasPlugin migration #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add user to AliasPlugin migration #11

wants to merge 1 commit into from

Conversation

stefanw
Copy link
Contributor

@stefanw stefanw commented Aug 7, 2023

AliasPlugin is also versioned and needs to be created with a .with_user now.

Aiky30
Aiky30 reviewed Jan 17, 2024
View reviewed changes
Copy link
Owner

@Aiky30 Aiky30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

djangocms-alias must have had changes to automatically create versions, you had to manually create one before so the check for is_versioning_enabled that creates the version using Version.objects.create may need to be removed / changed.

@stefanw stefanw force-pushed the add-user-alias-plugin branch 2 times, most recently from 3a2f4c4 to 362966a Compare April 18, 2024 14:59
@stefanw
Use username for version user
12834fb 
And don't save twice
@stefanw stefanw force-pushed the add-user-alias-plugin branch from 362966a to 12834fb Compare April 18, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aiky30 Aiky30 Aiky30 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanw @Aiky30