Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support addressing_style for rohmu s3 configurations #146

Closed

Conversation

bugant
Copy link
Contributor

@bugant bugant commented Oct 5, 2023

Support addressing_style for rohmu s3 configurations: this can be useful to support S3-compatible object storage that requires to use the (deprecated?) path style addressing.

@codecov-commenter
Copy link

Codecov Report

Merging #146 (066a3d3) into master (7477bfd) will increase coverage by 0.79%.
Report is 159 commits behind head on master.
The diff coverage is 85.88%.

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   87.02%   87.82%   +0.79%     
==========================================
  Files         122      136      +14     
  Lines        7648     9163    +1515     
==========================================
+ Hits         6656     8047    +1391     
- Misses        992     1116     +124     
Files Coverage Δ
astacus/common/asyncstorage.py 100.00% <100.00%> (ø)
astacus/common/cachingjsonstorage.py 96.49% <100.00%> (+0.06%) ⬆️
astacus/common/cassandra/client.py 92.85% <100.00%> (ø)
astacus/common/cassandra/config.py 75.75% <100.00%> (-11.75%) ⬇️
astacus/common/cassandra/utils.py 100.00% <100.00%> (ø)
astacus/common/etcd.py 94.11% <100.00%> (+0.11%) ⬆️
astacus/common/ipc.py 100.00% <100.00%> (ø)
astacus/common/limiter.py 100.00% <100.00%> (ø)
astacus/common/magic.py 100.00% <100.00%> (ø)
astacus/common/op.py 96.42% <100.00%> (ø)
... and 93 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bugant bugant closed this Oct 6, 2023
@bugant
Copy link
Contributor Author

bugant commented Oct 6, 2023

This is not strictly needed at the moment, so we can probably think of resolving this by including models from rohmu directly? If needed, will re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants