Use Rohmu models directly #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingon
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Otherwise this LGTM but I don't know about the clickhouse, and more specifically the string->bytes changes there. @kmichel-aiven ?
|
VSCode had red underlined them all but since Table is a pydantic model it converts str to bytes automatically (and using mypy with the pydantic plugin should pass) so I didn't really need to make that change and can revert |
kmichel-aiven
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some types were added to help with some debugging I was doing.