Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse: account for dropped KeeperMap tables #240

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

joelynch
Copy link
Contributor

@joelynch joelynch commented Sep 25, 2024

If the table was dropped the table path still exists but the data ZNode is removed. This leads to an error in backup.

@joelynch joelynch requested a review from a team September 25, 2024 09:42
@joelynch joelynch force-pushed the joelynch/keepermap-table-dropped branch 3 times, most recently from 330d74c to 654af32 Compare September 25, 2024 09:50
If the table was dropped the table path still exists but the data ZNode
still exists.  This leads to an error in backup
@joelynch joelynch force-pushed the joelynch/keepermap-table-dropped branch from 654af32 to 3361060 Compare September 25, 2024 10:11
@joelynch joelynch dismissed Khatskevich’s stale review September 25, 2024 10:13

Changes addressed

Copy link
Contributor

@Khatskevich Khatskevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & fixes the issue

@Khatskevich Khatskevich merged commit f99ce21 into main Sep 25, 2024
2 checks passed
@Khatskevich Khatskevich deleted the joelynch/keepermap-table-dropped branch September 25, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants