Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ClickHouse integration conftest #249

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

aris-aiven
Copy link
Contributor

The conditionals were valid for old setups. We can use named collections and ZooKeeper macro placeholders everywhere now.

The conditionals were valid for old setups. We can use named collections and
ZooKeeper macro placeholders everywhere now.
@aris-aiven aris-aiven requested a review from a team October 24, 2024 10:59
@aris-aiven aris-aiven marked this pull request as ready for review October 24, 2024 11:09
Copy link
Contributor

@dmitry-potepalov dmitry-potepalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitry-potepalov dmitry-potepalov merged commit 0d8d26a into main Oct 24, 2024
2 checks passed
@dmitry-potepalov dmitry-potepalov deleted the aris-clean-clickhouse-conftest branch October 24, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants