Zero copy tests #251
Merged
Zero copy tests #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joelynch
commented
Oct 25, 2024
joelynch
commented
- Set zero copy settings in tests.
- make sure object storage test table has data both on local and remote disk.
Khatskevich
reviewed
Oct 27, 2024
| @@ -313,6 +313,10 @@ async def setup_cluster_content(clients: Sequence[HttpClickHouseClient], clickho | |||
| await clients[0].execute(b"INSERT INTO default.in_object_storage VALUES (123, 'foo')") | |||
| await clients[1].execute(b"INSERT INTO default.in_object_storage VALUES (456, 'bar')") | |||
| await clients[2].execute(b"INSERT INTO default.in_object_storage VALUES (789, 'baz')") | |||
| # these should be routed to local disk | |||
There was a problem hiding this comment.
Why would they be routed to the local disk?
Even if there is a reason, it is better to test. (check if system.parts has parts on all disks for example)
There was a problem hiding this comment.
I don't think this is actually needed to reproduce the bugs I was seeing. Removed.
There was a problem hiding this comment.
I do not understand what is happening here now.
Commit says: "make sure object storage test table has data both on local and remote disk", but there are 0 new tests in this pr, and everything looks to work just as it was. Why are you now sure that the data is stored on both disks during tests?
joelynch
force-pushed
the
joelynch/astacus-zero-copy
branch
from
bcbaf05 to
cbe4a0a
Compare
Set zero copy settings in tests.
joelynch
force-pushed
the
joelynch/astacus-zero-copy
branch
from
cbe4a0a to
0ca9a9a
Compare
Khatskevich
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.