Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse: Fix race condition in DeleteDanglingObjectStorageFilesStep #259

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

joelynch
Copy link
Contributor

Files can be uploaded before a part appears in a backup manifest.
[DDB-1372]

Files can be uploaded _before_ a part appears in a backup manifest.
[DDB-1372]
@joelynch joelynch force-pushed the joelynch/gc-race-condition branch from a415e37 to 1a9cb63 Compare November 13, 2024 15:55
@joelynch joelynch force-pushed the joelynch/gc-race-condition branch from 1a9cb63 to b753a7e Compare November 13, 2024 15:56
@joelynch joelynch requested a review from a team November 13, 2024 15:59
Copy link
Contributor

@aris-aiven aris-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@aris-aiven aris-aiven merged commit 71a228f into main Nov 14, 2024
2 checks passed
@aris-aiven aris-aiven deleted the joelynch/gc-race-condition branch November 14, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants