Pause KeeperMap tables using read-only setting #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aris-aiven
force-pushed
the
aris-keeper-map-read-only
branch
from
f02b89b to
3f13739
Compare
Emitting a "table is read-only" is more precise and is already handled by Kafka Sink Connector for ClickHouse.
aris-aiven
force-pushed
the
aris-keeper-map-read-only
branch
from
3f13739 to
80b4c8a
Compare
tilman-aiven
approved these changes
Nov 20, 2024
| @@ -257,7 +254,7 @@ async def run_step(self, cluster: Cluster, context: StepsContext) -> Sequence[Ke | |||
|
|
|||
| async def handle_step_failure(self, cluster: Cluster, context: StepsContext) -> None: | |||
| try: | |||
| await KeeperMapTablesReadOnlyStep(clients=self.clients, allow_writes=True).run_step(cluster, context) | |||
| await KeeperMapTablesReadOnlyStep(self.clients).run_step(cluster, context) | |||
There was a problem hiding this comment.
for visibility: this is rephrased from allow_writes=True to _is_read_only=False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitting a "table is read-only" is more precise
and is already handled by Kafka Sink Connector
for ClickHouse.