Skip to content

Commit

Permalink
Update e2e test file upload step (#2546)
Browse files Browse the repository at this point in the history
Signed-off-by: Mirjam Aulbach <[email protected]>
  • Loading branch information
programmiri authored Aug 20, 2024
1 parent f6ff1fe commit 0fdec2d
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/end-to-end-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ jobs:
# be immediately ready to accept connections, so the retry makes sure
# we're giving it (hopefully) enough time to be ready.
- name: Make sure Klaw is reachable
id: klaw-build-reachable
run: |
retries=5 # Number of retries
interval=5 # Initial retry interval in seconds
Expand Down Expand Up @@ -125,19 +126,15 @@ jobs:
run: pnpm playwright install --with-deps chromium

- name: Run Playwright tests
id: playwright-test-run
working-directory: ./e2e
run: BASE_URL=http://${{ steps.containerIp.outputs.CONTAINER_IP }}:9097 pnpm __test

- name: Upload Playwright artifacts
uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
# Upload whether steps before where a failure, but only when the playwright tests did run
# This way we make sure we don't attempt to upload files that are not there, bc.
# for example the build has failed.
if: ${{ always() && steps.playwright-test-run.status == 'completed' }}
if: ${{ !cancelled() }}
with:
name: playwright-report
path: playwright-report/
path: ./e2e/playwright-report/
retention-days: 5

- name: Teardown Klaw
Expand Down

0 comments on commit 0fdec2d

Please sign in to comment.