fix RECORDSET returning empty columns if there's no matched rows issu…

[aleeekhaan]

Reference issue #1547

[mathiasrw]

Lovely!

Any chance you can add a test file for this so we dont accidentally introduce the problem again when we rewrite things in a few years?

[aleeekhaan]

Sure. I'll add a test case for this as well.

[aleeekhaan]

Hi @mathiasrw, I have edited the test case you created to use a custom function for checking that the columns exist instead on using deepEqual. Please review and let me know if any changes are required.

[mathiasrw]

I see the idea - just to make sure the columns are there - but we cant suddenly provide a different response format.

Please refert to deep equal and see if you can get it to return columnId without

  "dbenum": [undefined]
  "dbprecision": [undefined]
  "dbsize": [undefined]
  "dbtypeid": "INT"

[aleeekhaan]

@mathiasrw The reason deepEqual fails because in the test case we only give the columnid while the actual result also has some other fields

"dbenum": [undefined] "dbprecision": [undefined] "dbsize": [undefined] "dbtypeid": "INT"

Can we remove these fields by writing a function that modifies the response for the recordset. Will this approach be appropriate?

[mathiasrw]

Yep. That is what I was working towards with 4feca50#diff-daa185eed55b4159786a570955a6a87c12074d6ed316e7c14bd1ef711aabf0d8R474

[harisiqbal12]

@mathiasrw What's the update on this?

[mathiasrw]

@harisiqbal12 Hmmm. Good question. Let me look into this over the weekend.

[mathiasrw]

If anyone can pick this up that would be amazing.