-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page Select Component #2582
Merged
tvdeyen
merged 5 commits into
AlchemyCMS:main
from
sascha-karnatz:update_javascript/page_select
Sep 27, 2023
Merged
Page Select Component #2582
tvdeyen
merged 5 commits into
AlchemyCMS:main
from
sascha-karnatz:update_javascript/page_select
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/javascript/alchemy_admin/components/alchemy_html_element.js
Outdated
Show resolved
Hide resolved
sascha-karnatz
force-pushed
the
update_javascript/page_select
branch
8 times, most recently
from
September 22, 2023 06:41
2487803
to
25802ef
Compare
tvdeyen
reviewed
Sep 22, 2023
app/javascript/alchemy_admin/components/alchemy_html_element.js
Outdated
Show resolved
Hide resolved
sascha-karnatz
force-pushed
the
update_javascript/page_select
branch
from
September 22, 2023 13:16
78b34a4
to
d362717
Compare
sascha-karnatz
force-pushed
the
update_javascript/page_select
branch
from
September 22, 2023 13:21
d362717
to
932d7c4
Compare
tvdeyen
requested changes
Sep 26, 2023
The boolean values are attributes without an value like the default HTML standard e.g. disabled or checked. Also attributes with dashes are now casted to underscore.
sascha-karnatz
force-pushed
the
update_javascript/page_select
branch
from
September 26, 2023 10:02
932d7c4
to
947d502
Compare
tvdeyen
reviewed
Sep 26, 2023
Add page select component, which wraps the select2 initialization. The jquery - dependencies is only necessary for testing purposes to import jquery, which otherwise only available via Sprockets.
Add a view component to make it easier to use the page select web component in erb views.
Use the new web component to create the page selects. It was necessary to encapsulate the node form mechanic into an own component.
It is now replaced by the alchemy-page-select - web component. The page.hbs file is still in use, because there is another page selector in the Alchemy Link Dialog.
sascha-karnatz
force-pushed
the
update_javascript/page_select
branch
from
September 26, 2023 19:31
947d502
to
2435410
Compare
tvdeyen
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor 🍰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Upgrade
If you use the
alchemyPageSelect
- function before, you have to upgrade to the newalchemy-page-select
web component, which contains the same feature set.Replace these code block:
with the ViewComponent (which is a wrapper for the web component):
Checklist