Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rails 8.0 #3032

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Allow Rails 8.0 #3032

wants to merge 4 commits into from

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Sep 8, 2024

What is this pull request for?

Allows to update to Rails 8.0

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (b4b2471) to head (5e59ac8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3032   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         236      236           
  Lines        6334     6334           
=======================================
  Hits         6118     6118           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This pull request has not seen any activiy in a long time.
Probably because of missing tests or a necessary rebase.
This PR will be closed in 7 days if no further activity happens.

@github-actions github-actions bot added the Stale label Dec 14, 2024
@tvdeyen tvdeyen marked this pull request as ready for review December 14, 2024 12:24
@tvdeyen tvdeyen requested a review from a team as a code owner December 14, 2024 12:24
@tvdeyen tvdeyen changed the title wip: Allow Rails 8.0 Allow Rails 8.0 Dec 14, 2024
@tvdeyen tvdeyen removed their assignment Dec 14, 2024
@tvdeyen tvdeyen added this to the 8.0 milestone Dec 14, 2024
@tvdeyen tvdeyen removed the Stale label Dec 14, 2024
Rails 8.0 (the default Rails we use on CI) needs at least
Ruby 3.2. We still support 3.1 and set the linter to check
for Ruby 3.1 syntax.
@tvdeyen tvdeyen modified the milestones: 8.0, 7.4 Dec 14, 2024
Rails 8 needs at least Ruby 3.2
This needs to be defined as member in order to work with Rails 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant