Skip to content

battery: Add {cycles}, {health} format replacements #442

battery: Add {cycles}, {health} format replacements

battery: Add {cycles}, {health} format replacements #442

Re-run triggered April 12, 2024 11:36
Status Failure
Total duration 4m 48s
Artifacts

clang-tidy.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
build
Process completed with exit code 1.
src/modules/battery.cpp:184:1 [readability-const-return-type]: src/modules/battery.cpp#L184
return type 'const std::tuple<uint8_t, float, std::string, float, uint16_t, float>' (aka 'const tuple<unsigned char, float, basic_string<char>, float, unsigned short, float>') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
src/modules/battery.cpp:184:97 [readability-function-cognitive-complexity]: src/modules/battery.cpp#L184
function 'getInfos' has cognitive complexity of 224 (threshold 25)
src/modules/battery.cpp:255:14 [readability-identifier-naming]: src/modules/battery.cpp#L255
invalid case style for variable 'largest_design_capacity'
src/modules/battery.cpp:256:14 [readability-identifier-naming]: src/modules/battery.cpp#L256
invalid case style for variable 'main_bat_cycle_count'
src/modules/battery.cpp:257:11 [readability-identifier-naming]: src/modules/battery.cpp#L257
invalid case style for variable 'main_bat_health_percent'
src/modules/battery.cpp:257:37 [readability-uppercase-literal-suffix]: src/modules/battery.cpp#L257
floating point literal has suffix 'f', which is not uppercase
src/modules/battery.cpp:360:12 [readability-identifier-naming]: src/modules/battery.cpp#L360
invalid case style for variable 'is_main_battery'
src/modules/battery.cpp:361:16 [readability-identifier-naming]: src/modules/battery.cpp#L361
invalid case style for variable 'cycle_count'
src/modules/battery.cpp:373:17 [readability-identifier-naming]: src/modules/battery.cpp#L373
invalid case style for variable 'bat_health_percent'
src/modules/battery.cpp:374:42 [readability-uppercase-literal-suffix]: src/modules/battery.cpp#L374
floating point literal has suffix 'f', which is not uppercase