Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

niri/workspaces: Allow restricting the module to an output #3842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

algernon
Copy link

To be able to show the workspaces for a given output only, which may be different from the output the bar is displayed on, allow restricting the niri/workspaces module to a single output.

The default - when the output option is unset - remains the same as before.

This lets me set up Waybar to do this:

image

The "main" and "social" modules on the left are configured like this:

    "niri/workspaces#left": {
        "current-only": true,
        "disable-click": true,
        "output": "DP-1",
        "format": "🄻 {value}"
    },
    "niri/workspaces#right": {
        "current-only": true,
        "disable-click": true,
        "output": "HDMI-A-1",
        "format": "🅁 {value}"
    },

In other words, this lets me show the active workspace on both my displays, on a single bar.

To be able to show the workspaces for a given output only, which may be
different from the output the bar is displayed on, allow restricting the
niri/workspaces module to a single output.

The default - when the `output` option is unset - remains the same as
before.

Signed-off-by: Gergely Nagy <[email protected]>
@YaLTeR
Copy link
Contributor

YaLTeR commented Dec 25, 2024

I was quite confused reading this PR title and description, I think instead of the word "restrict" it would be clearer to say that this allows overriding or setting the output. As in, by default (with current-only) it shows the current output, and by setting "output" you can override that.

Also probably even in your formulation, it should do the overriding/restricting even if current-only is false?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants